Escape NavLink path to allow special characters in path. Fixes #5584 #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want this to apply higher up than just the NavLink component? |
|
@timdorr I don't think so. The |
|
BTW, no-whitespace mode makes this a little easier to grok on the diff: https://github.com/ReactTraining/react-router/pull/5596/files?w=1 |
|
OK, cleaned that up. LGTM 👍 |
pshrmn
approved these changes
Oct 6, 2017
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jun 6, 2018
179: Update dependency react-router-dom to v4.3.0 r=magopian a=renovate[bot] This Pull Request updates dependency [react-router-dom](https://github.com/ReactTraining/react-router) from `v4.2.2` to `v4.3.0` <details> <summary>Release Notes</summary> ### [`v4.3.0`](https://github.com/ReactTraining/react-router/blob/master/CHANGELOG.md#v430httpsgithubcomReactTrainingreact-routercomparev420v430) [Compare Source](remix-run/react-router@v4.3.0-rc.3...a27bc56) > Jun 6, 2018 * Use the `pretty` option in generatePath ([#​6172] by @​sibelius) * aria-current has incorrect value "true" ([#​6118] by @​brandonrninefive) * Redirect with parameters ([#​5209] by @​dlindenkreuz) * Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) * Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) * Expose `generatePath` ([#​5661] by @​rybon) * Use named import of history module. ([#​5589] by @​RoboBurned) * Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) * Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) * Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) * Use Prettier on the code ([e6f9017] by @​mjackson) * Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) * Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​6172]: `remix-run/react-router#6172 [#​6118]: `remix-run/react-router#6118 [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- ### [`v4.3.0-rc.3`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.3) [Compare Source](remix-run/react-router@v4.3.0-rc.2...v4.3.0-rc.3) - Fix broken UMD builds. - Add sideEffects: false for webpack tree shaking (#​6082 by @​taylorc93) --- ### [`v4.3.0-rc.2`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.2) [Compare Source](remix-run/react-router@v4.3.0-rc.1...v4.3.0-rc.2) - Bump `hoist-non-react-statics` for React 16.3. - Missing `generatePath` in `react-router-dom` package. --- ### [`v4.3.0-rc.1`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.1) [Compare Source](remix-run/react-router@v4.2.2...v4.3.0-rc.1) > Mar 26, 2018 - Redirect with parameters ([#​5209] by @​dlindenkreuz) - Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) - Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) - Expose `generatePath` ([#​5661] by @​rybon) - Use named import of history module. ([#​5589] by @​RoboBurned) - Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) - Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) - Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) - Use Prettier on the code ([e6f9017] by @​mjackson) - Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) - Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jun 6, 2018
178: Update dependency react-router to v4.3.0 r=magopian a=renovate[bot] This Pull Request updates dependency [react-router](https://github.com/ReactTraining/react-router) from `v4.2.0` to `v4.3.0` <details> <summary>Release Notes</summary> ### [`v4.3.0`](https://github.com/ReactTraining/react-router/blob/master/CHANGELOG.md#v430httpsgithubcomReactTrainingreact-routercomparev420v430) [Compare Source](remix-run/react-router@v4.3.0-rc.3...v4.3.0) > Jun 6, 2018 * Use the `pretty` option in generatePath ([#​6172] by @​sibelius) * aria-current has incorrect value "true" ([#​6118] by @​brandonrninefive) * Redirect with parameters ([#​5209] by @​dlindenkreuz) * Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) * Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) * Expose `generatePath` ([#​5661] by @​rybon) * Use named import of history module. ([#​5589] by @​RoboBurned) * Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) * Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) * Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) * Use Prettier on the code ([e6f9017] by @​mjackson) * Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) * Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​6172]: `remix-run/react-router#6172 [#​6118]: `remix-run/react-router#6118 [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- ### [`v4.3.0-rc.3`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.3) [Compare Source](remix-run/react-router@v4.3.0-rc.2...v4.3.0-rc.3) - Fix broken UMD builds. - Add sideEffects: false for webpack tree shaking (#​6082 by @​taylorc93) --- ### [`v4.3.0-rc.2`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.2) [Compare Source](remix-run/react-router@v4.3.0-rc.1...v4.3.0-rc.2) - Bump `hoist-non-react-statics` for React 16.3. - Missing `generatePath` in `react-router-dom` package. --- ### [`v4.3.0-rc.1`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.1) [Compare Source](remix-run/react-router@v4.2.0...v4.3.0-rc.1) > Mar 26, 2018 - Redirect with parameters ([#​5209] by @​dlindenkreuz) - Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) - Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) - Expose `generatePath` ([#​5661] by @​rybon) - Use named import of history module. ([#​5589] by @​RoboBurned) - Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) - Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) - Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) - Use Prettier on the code ([e6f9017] by @​mjackson) - Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) - Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>
This was referenced Sep 22, 2018
Open
This was referenced Oct 26, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Jan 7, 2019
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toprop passed to NavLink needs to have special characters escaped when passed to the Route component. This change allows NavLink to be used for urls with any characters.Example routes that will be taken literally: