NavLink not working without pathname

[hellqvist]

Version

master (commit: e6f9017)

Test Case

https://codesandbox.io/s/3x3oxk33k6

Steps to reproduce

Add a NavLink without pathname, only search in the to object.

Expected Behavior

Classname active shall be added on all paths as long as the query matches the search value.

Actual Behavior

TypeError
Cannot read property 'replace' of undefined

Before escaping characters in path we need to verify that it's not null or undefined.

[timdorr]

We should add an invariant of some sort. pathname is a required field (you can't delete window.location.pathname).

[hellqvist]

No but Link (and NavLink) is working today with only search set. It will only set the query and leave the actual path as it is. In 4.2.2 NavLink is working fine with only search. As long as no special characters is used in the path

[timdorr]

That's because #5596 landed after 4.2.2 was released.

But that brings up a good point. The check for a blank pathname would be better.

[timdorr]

Fixed in 6d9c425. Thanks!

[hellqvist]

Great job