-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving docs #14
Open
vicmeow
wants to merge
10
commits into
ReactJSGirls:master
Choose a base branch
from
vicmeow:docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improving docs #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken link at the end btw
Updating some wording for clarity
Not sure if this is accurate 😅
Code used index to remove cat, but description said URL. Also clarified some things.
Added a link to a previous part that mentioned arrow functions and made some sentences clearer.
Hm... I think this can still be improved further.
walaura
approved these changes
Jul 12, 2019
bikkimahato
reviewed
Oct 16, 2022
@@ -75,10 +75,10 @@ import { GoTrashcan } from 'react-icons/go' | |||
\n | |||
const favoriteCats = () => ( | |||
<ul className="favorite-cats"> | |||
{favoriteCats.map((cat, index) => ( | |||
{favoriteCats.map(cat => ( | |||
<li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key
attribute should be added
<ul className="favorite-cats"> | ||
{cats.map((cat, index) => ( | ||
{cats.map(cat => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes, and I think part 9 can still be improved!