Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving docs #14

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improving docs #14

wants to merge 10 commits into from

Conversation

vicmeow
Copy link

@vicmeow vicmeow commented Apr 6, 2019

Made some changes, and I think part 9 can still be improved!

Broken link at the end btw
Updating some wording for clarity
Not sure if this is accurate 😅
Code used index to remove cat, but description said URL. Also clarified some things.
Added a link to a previous part that mentioned arrow functions and made some sentences clearer.
Hm... I think this can still be improved further.
@@ -75,10 +75,10 @@ import { GoTrashcan } from 'react-icons/go'
\n
const favoriteCats = () => (
<ul className="favorite-cats">
{favoriteCats.map((cat, index) => (
{favoriteCats.map(cat => (
<li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key attribute should be added

<ul className="favorite-cats">
{cats.map((cat, index) => (
{cats.map(cat => (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants