feat(patcher): Improve installation #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aliernfrog
commented
Sep 1, 2024
aliernfrog
commented
- Renamed "Root" installation type to "Mount"
- Made the "Cancel" button in InstallPickerDialog a text button
- Made InstallPickerDialog only show up if the device is rooted
- Reduced remoteFS timeout to 20 seconds from 120 seconds (it was taking too long for the installation to fail when root access was denied)
* (UI) make the "Cancel" button in InstallPickerDialog a TextButton to match M3 guidelines * add check for Root and only show InstallPickerDialog if rooted, do a regular installation otherwise * reduced remoteFS timeout to 20 seconds from 120
validcube
added
the
ReVanced Manager Compose
TheAabedKhan
approved these changes
Sep 9, 2024
Axelen123
requested changes
Sep 16, 2024
app/src/main/java/app/revanced/manager/ui/viewmodel/PatcherViewModel.kt
Outdated
Show resolved
Hide resolved
Axelen123
requested changes
Sep 17, 2024
| private val rootInstaller: RootInstaller by inject() | ||
| val rootInstaller: RootInstaller by inject() |
There was a problem hiding this comment.
Make rootInstaller private and provide hasRootAccess through the viewmodel instead (for consistency).
There was a problem hiding this comment.
Done with b6dc75a
Axelen123
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.