bug: `1.25.1` crashed with a `NullPointerException`, due to being unable to invoke `InstallerReceiver`, when updating itself.

[RokeJulianLockhart]

Bug description

FATAL EXCEPTION: main
Process: app.revanced.manager.flutter, PID: 3726
java.lang.RuntimeException: Unable to start receiver app.revanced.manager.flutter.utils.packageInstaller.InstallerReceiver: java.lang.NullPointerException
	at android.app.ActivityThread.handleReceiver(ActivityThread.java:4782)
	at android.app.ActivityThread.-$$Nest$mhandleReceiver(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2437)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8751)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:892)
Caused by: java.lang.NullPointerException
	at app.revanced.manager.flutter.utils.packageInstaller.InstallerReceiver.onReceive(Unknown Source:63)
	at android.app.ActivityThread.handleReceiver(ActivityThread.java:4773)
	... 9 more

Version of ReVanced Manager and version & name of app you are patching

versionName=1.25.1
versionCode=101800065

Installation method

Regular

ReVanced Manager logs

--------- beginning of crash
08-23 13:33:40.815  3726  3726 E AndroidRuntime: FATAL EXCEPTION: main
08-23 13:33:40.815  3726  3726 E AndroidRuntime: Process: app.revanced.manager.flutter, PID: 3726
08-23 13:33:40.815  3726  3726 E AndroidRuntime: java.lang.RuntimeException: Unable to start receiver app.revanced.manager.flutter.utils.packageInstaller.InstallerReceiver: java.lang.NullPointerException
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.app.ActivityThread.handleReceiver(ActivityThread.java:4782)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.app.ActivityThread.-$$Nest$mhandleReceiver(Unknown Source:0)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2437)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:107)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:232)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:317)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8751)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:892)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: Caused by: java.lang.NullPointerException
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at app.revanced.manager.flutter.utils.packageInstaller.InstallerReceiver.onReceive(Unknown Source:63)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	at android.app.ActivityThread.handleReceiver(ActivityThread.java:4773)
08-23 13:33:40.815  3726  3726 E AndroidRuntime: 	... 9 more
--------- beginning of main
08-23 13:39:06.797  6596  6596 I manager.flutter: Using CollectorTypeCC GC.
08-23 13:39:06.806  6596  6596 E manager.flutter: Not starting debugger since process cannot load the jdwp agent.
08-23 13:39:06.816  6596  6596 D nativeloader: Load libframework-connectivity-tiramisu-jni.so using APEX ns com_android_tethering for caller /apex/com.android.tethering/javalib/framework-connectivity-t.jar: ok
08-23 13:39:06.840  6596  6596 D nativeloader: Load libstats_jni.so using APEX ns com_android_os_statsd for caller /apex/com.android.os.statsd/javalib/framework-statsd.jar: ok
08-23 13:39:06.846  6596  6596 D ApplicationLoaders: Returning zygote-cached class loader: /system_ext/framework/androidx.window.extensions.jar
08-23 13:39:06.846  6596  6596 D ApplicationLoaders: Returning zygote-cached class loader: /system_ext/framework/androidx.window.sidecar.jar
08-23 13:39:06.856  6596  6596 D nativeloader: Configuring clns-7 for other apk /data/app/~~Mdja3-6U76UIJ-wDaqmziA==/app.revanced.manager.flutter-3tMG2rT_2CFfd5hmKJE7eQ==/base.apk. target_sdk_version=35, uses_libraries=, library_path=/data/app/~~Mdja3-6U76UIJ-wDaqmziA==/app.revanced.manager.flutter-3tMG2rT_2CFfd5hmKJE7eQ==/lib/arm64:/data/app/~~Mdja3-6U76UIJ-wDaqmziA==/app.revanced.manager.flutter-3tMG2rT_2CFfd5hmKJE7eQ==/base.apk!/lib/arm64-v8a, permitted_path=/data:/mnt/expand:/data/user/0/app.revanced.manager.flutter
08-23 13:39:06.858  6596  6596 D CompatChangeReporter: Compat change id reported: 202956589; UID 10244; state: ENABLED
08-23 13:39:06.861  6596  6596 I Perf    : Connecting to perf service.
08-23 13:39:06.864  6596  6596 V GraphicsEnvironment: Currently set values for:
08-23 13:39:06.864  6596  6596 V GraphicsEnvironment:   angle_gl_driver_selection_pkgs=[]
08-23 13:39:06.864  6596  6596 V GraphicsEnvironment:   angle_gl_driver_selection_values=[]
08-23 13:39:06.864  6596  6596 V GraphicsEnvironment: Global.Settings values are invalid: number of packages: 0, number of values: 0
08-23 13:39:06.864  6596  6596 V GraphicsEnvironment: Updatable production driver is not supported on the device.
08-23 13:39:06.869  6596  6596 D CompatChangeReporter: Compat change id reported: 279646685; UID 10244; state: ENABLED
08-23 13:39:06.911  6596  6620 D nativeloader: Load /data/app/~~Mdja3-6U76UIJ-wDaqmziA==/app.revanced.manager.flutter-3tMG2rT_2CFfd5hmKJE7eQ==/lib/arm64/libflutter.so using class loader ns clns-7 (caller=/data/app/~~Mdja3-6U76UIJ-wDaqmziA==/app.revanced.manager.flutter-3tMG2rT_2CFfd5hmKJE7eQ==/base.apk): ok
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: QUALCOMM build                   : 923a446bf8, I23d7d7df15
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Build Date                       : 09/05/24
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: OpenGL ES Shader Compiler Version: EV031.35.01.12
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Local Branch                     : 
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Remote Branch                    : refs/tags/AU_LINUX_ANDROID_LA.UM.9.14.11.00.00.571.148
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Remote Branch                    : NONE
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Reconstruct Branch               : NOTHING
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Build Config                     : S P 10.0.7 AArch64
08-23 13:39:06.940  6596  6596 I AdrenoGLES-0: Driver Path                      : /vendor/lib64/egl/libGLESv2_adreno.so
08-23 13:39:06.944  6596  6596 I AdrenoGLES-0: PFP: 0x016dc094, ME: 0x00000000
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: onAttachedToEngine - IN
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: doOnAttachedToEngine - IN
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: doOnAttachedToEngine - OUT
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: onAttachedToEngine - OUT
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: onAttachedToActivity
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: doOnAttachedToActivity - IN
08-23 13:39:06.993  6596  6596 D FlutterFileDialogPlugin: doOnAttachedToActivity - OUT
08-23 13:39:07.013  6596  6596 D CompatChangeReporter: Compat change id reported: 309578419; UID 10244; state: ENABLED
08-23 13:39:07.042  6596  6596 D CompatChangeReporter: Compat change id reported: 306666082; UID 10244; state: ENABLED
08-23 13:39:07.042  6596  6596 I WindowExtensionsImpl: Initializing Window Extensions, vendor API level=6, activity embedding enabled=true
08-23 13:39:07.061  6596  6596 W libc    : Access denied finding property "vendor.gpp.create_frc_extension"
08-23 13:39:07.064  6596  6596 W libc    : Access denied finding property "vendor.gpp.create_frc_extension"
08-23 13:39:07.515  6596  6596 I Choreographer: Skipped 39 frames!  The application may be doing too much work on its main thread.
08-23 13:39:07.558  6973  6973 W sh      : type=1400 audit(0.0:435250): avc:  denied  { read } for  name="/" dev="dm-7" ino=2 scontext=u:r:untrusted_app:s0:c244,c256,c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir permissive=0 app=app.revanced.manager.flutter
08-23 13:39:07.566  6973  6973 W sh      : type=1400 audit(0.0:435251): avc:  denied  { read } for  name="/" dev="dm-7" ino=2 scontext=u:r:untrusted_app:s0:c244,c256,c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir permissive=0 app=app.revanced.manager.flutter
08-23 13:39:07.578  6973  6973 W sh      : type=1400 audit(0.0:435252): avc:  denied  { read } for  name="/" dev="dm-7" ino=2 scontext=u:r:untrusted_app:s0:c244,c256,c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir permissive=0 app=app.revanced.manager.flutter
08-23 13:39:07.590  6973  6973 W sh      : type=1400 audit(0.0:435253): avc:  denied  { read } for  name="/" dev="dm-7" ino=2 scontext=u:r:untrusted_app:s0:c244,c256,c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir permissive=0 app=app.revanced.manager.flutter
08-23 13:39:07.598  6973  6973 W sh      : type=1400 audit(0.0:435254): avc:  denied  { read } for  name="/" dev="dm-7" ino=2 scontext=u:r:untrusted_app:s0:c244,c256,c512,c768 tcontext=u:object_r:rootfs:s0 tclass=dir permissive=0 app=app.revanced.manager.flutter
08-23 13:39:07.951  6596  6596 I Choreographer: Skipped 37 frames!  The application may be doing too much work on its main thread.
08-23 13:39:07.974  6596  6596 I flutter : dynamic_color: Core palette detected.
08-23 13:39:08.450  6596  6596 I Choreographer: Skipped 42 frames!  The application may be doing too much work on its main thread.
08-23 13:39:12.241  6596  7613 D ProfileInstaller: Installing profile for app.revanced.manager.flutter

Patch logs

Inapplicable.

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• The bug is only related to ReVanced Manager.

[RokeJulianLockhart]

#2494 (comment) may be relevant.

[oSumAtrIX]

No idea how this can occur, because

                PackageInstallerManager.result = result

is set before the receiver is called. Maybe an Android quirk with activites etc? @Axelen123

[validcube]

@RokeJulianLockhart Hi, what Android version are you currently using when the crash happened?

[RokeJulianLockhart]

@validcube, adb shell getprop | grep ro.build returns:

[ro.build.version.release]: [15]
[ro.build.display.id]: [FP5.VT28.C.042.20250623]

Could this be related to OEM-specific issues, like ReVanced/GmsCore#226 (comment)...?

[oSumAtrIX]

I have no idea, however from what I know android "clears" activites or similar and restores them again at some point to save battery, memory or CPU or something like that. So maybe result is set back to null when the activity is restored which might be more aggressive in your ROM, so this restoring logic would be needed to be parcelized I think. However, new compose manager may resolve this issue, so this can be closed once it's merged (soon)

[validcube]

@validcube, adb shell getprop | grep ro.build returns:

Could this be related to OEM-specific issues, like ReVanced/GmsCore#226 (comment)...?

This may be issues with dart dependency (or ours problem) however I can't check since starting with version 15 android set most of the functions/stuff we actually use to nullable.

[RokeJulianLockhart]

#2707 (comment)

@oSumAtrIX, you may be correct, per forum.fairphone.com/t/124216/9.

[oSumAtrIX]

Well, it's not necessarily incorrect behavior. Instead the killing/restoring needs to be handled on our end.

[oSumAtrIX]

@validcube, adb shell getprop | grep ro.build returns:
Could this be related to OEM-specific issues, like ReVanced/GmsCore#226 (comment)...?

This may be issues with dart dependency (or ours problem) however I can't check since starting with version 15 android set most of the functions/stuff we actually use to nullable.

Dart is unrelated

[Axelen123]

Does the app get updated in the end? It could be that Android kills apps when they are updated, which means all in memory state gets lost. The result thing would be null if the system decides to deliver the result after restarting the app.
The correct thing to do would be to save state to ensure results can be handled even if the process dies during installation, or just use ? instead of !!.

[oSumAtrIX]

We can't use ? Because the result is needed, the state needs to be saved and restored but how?