Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDoc Type definitions #24

Merged
merged 26 commits into from
May 5, 2020
Merged

Add JSDoc Type definitions #24

merged 26 commits into from
May 5, 2020

Conversation

Raynos
Copy link
Owner

@Raynos Raynos commented May 3, 2020

There are a few changes here as well not related
to the type definitions

  • cleanup benchmark / package.json
  • Refactor static get type to use a Map and a function
    instead of storing the type on __type
  • Make null checks explicit
  • Use Reflect.get where applicable
  • Cleanup do {} while loop.
  • Handle case where stack is null or empty

TODO:

  • Add tsdocstandard
  • Add type-coverage

Raynos added 16 commits May 2, 2020 21:47
Previously we cached the type as a field __type on the object
in a shared getter defined as a static property on the class.

Now we cache explicitely in a Map. The keyspace of unique class
names for errors should be reasonably bounded and we have a little
function that can read/write from this cache map.
This cleans up the do while loop and makes it a while loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant