优化部分代码规范 #530
Merged
优化部分代码规范 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayWangQvQ
requested changes
May 24, 2023
RayWangQvQ
requested changes
May 24, 2023
src/Ray.BiliBiliTool.Config/EnvironmentVariablesExcludeEmptyConfigurationProvider.cs
Show resolved
Hide resolved
src/Ray.BiliBiliTool.Config/EnvironmentVariablesExcludeEmptyConfigurationSource.cs
Show resolved
Hide resolved
|
thx for your PR，please check the review comments, and we can talk about it freely here~ |
|
这下应该差不多了，转化为了PR改了一下设置。。PR完又改回去了（狗头） |
RayWangQvQ
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【内容】：
fork后部署到railay，用docker的方式跑。发现添加环境变量后也没有切换到login任务上，就看了一眼代码想追追。
结果没有追出来，不过顺手优化了部分代码，未修改过逻辑，让代码更好阅读一点（顺便混个贡献者233）