Avoid using sizeof('\0') to compute size for NUL-terminator.
#277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression `sizeof('\0')` evaluates to `sizeof(int)`, which does not reflect
the intent in the code. It has been replaced with `1 /* NUL */` for clarity.
This issue was originally reported by наб <[email protected]>
who also proposed this patch.
thejayps
added
the
essential
rptb1
added
the
low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression
sizeof('\0')evaluates tosizeof(int), which does not reflect the intent in the code. It has been replaced with1 /* NUL */for clarity.This issue was originally reported by наб [email protected] who also proposed this patch.
Fixes #276