Skip to content

Conversation

@sphericale
Copy link
Contributor

The Qt wallet transaction history uses 'RVN' for all RVN transactions even if a different display unit is chosen in the options. This has occasionally been a cause of confusion for some users.

These changes:

  • Use the correct unit (e.g. RVN, mRVN or μRVN) in the transaction history 'Asset' column and recent transactions
  • Removes display unit from the 'Amount' column (as asset amounts are not in RVN)
  • Further reduces potential for confusion by displaying asset names in a different colour (I chose raven blue)

shot_191206_162717

Copy link
Contributor

@blondfrogs blondfrogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Changes seem fine

@spyder46n2
Copy link
Contributor

Looks like the AWS ARM build failed to compile the external dependencies. This us a semi-random failure and this PR does not appear to be the cause of the build failure. I restarted and will merge once the builds finish.

@spyder46n2 spyder46n2 merged commit 3742b1a into RavenProject:develop Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants