Repair OSX static builds #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static and gitian builds fail due to the inclusion of non statically compiled, OS dependant, dependancies being included in the static build process. This otools append is not required in a dmg build so long as the depends folder (aka static build or gitian build) process is followed, which is the reccommended method to generate reliable binaries.
Contributor
|
Closing because of the duplicate PR #405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static and gitian builds fail due to the inclusion of non statically compiled, OS dependant, dependancies being included in the static build process. This otools append is not required in a dmg build so long as the depends folder (aka static build or gitian build) process is followed, which is the reccommended method to generate reliable binaries. Please stop attempting to generate binaries with the existing methods. They generally fail to run in multiple ways.