Avoid redefining thread priority constants #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.1.0 - Merge to Master
spyder46n2
approved these changes
Oct 15, 2018
Contributor
spyder46n2
left a comment
spyder46n2
left a comment
There was a problem hiding this comment.
Compiled and verified that this is the correct (expected) behavior. Nice find.
Contributor
|
@standard-error - We normally don't commit directly into Master, the process dictates that this would go into the Develop branch first and would get merged to Master during the next release. I'm happy to move this over to Develop, but I'd rather you get credit. Can you move this to merge to Develop and I'll merge it in... |
Contributor
Author
|
Changed to Develop branch, cheers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, PRIO_MAX is not defined so that in compat.h THREAD_PRIORITY_LOWEST is redefined as 20 (which on Windows is higher than real time priority).
The result is the call to SetThreadPriority(THREAD_PRIORITY_LOWEST) in miner.cpp fails and the miner threads actually run at normal priority.
Possibly not a huge issue at this point as I don't expect there are too many wallet miners left but if nothing else cleans up some compiler warning spam.