Remove the ability to chain reissue transactions #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfox
approved these changes
Aug 22, 2018
| // 50000 * 82 Bytes == 4.1 Mb | ||
| #define MAX_CACHE_ASSETS_SIZE 50000 | ||
|
|
||
| extern std::map<uint256, std::string> mapReissuedTx; |
Contributor
There was a problem hiding this comment.
maybe a couple of brief comments here to explain semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because reissue transaction require a state based check from memory or database to verify the validity of the reissue transaction. Only one reissue transaction can be made per asset until the transaction is accepted into a block.
If a transaction doesn't contain a necessary fee to get accepted into a block, the owner of the asset will have to wait until the transaction is removed/expires from the mempool to be able to reissue the asset again.