Add ability to create assets of other types with the GUI #243
Conversation
cfox
left a comment
cfox
left a comment
There was a problem hiding this comment.
Looks good. Nothing concerning except maybe the 30-char check in asset list setup.
| REISSUE | ||
| }; | ||
|
|
||
| enum IssueAssetType |
There was a problem hiding this comment.
Could these be moved somewhere into qt codebase since they only seem to apply there?
| GetAllOwnedAssets(model->getWallet(), names); | ||
| for (auto item : names) { | ||
| std::string name = QString::fromStdString(item).split("!").first().toStdString(); | ||
| if (name.size() != 30) |
There was a problem hiding this comment.
What is this check for? I think we could have a 30-char asset name (plus !)..
There was a problem hiding this comment.
Yeah. So, I am splitting the ! off of these assets names. Then after that if they are < 30 characters. They won't show up because the asset name is already at the limit
src/qt/createassetdialog.cpp
Outdated
| void CreateAssetDialog::checkAvailabilityClicked() | ||
| { | ||
| QString name = ui->nameText->text(); | ||
| QString name = ""; |
There was a problem hiding this comment.
these lines duplicate the block starting at line 160 -- could possibly be consolidated
There was a problem hiding this comment.
Consolidated into function
src/qt/createassetdialog.cpp
Outdated
| } else { | ||
| address = ui->addressText->text(); | ||
| } | ||
| QString name = ""; |
There was a problem hiding this comment.
Consolidated into function
No description provided.