Fix test_runner-configure, mempool_limit test, and add nonce to miner_tests #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_runner.py functional test wouldn't run because of a change made a while back to the configure options (splitting the utils into raven-cli and raven-tx). This fixes the default behavior to allow the test_runner to run when raven-cli is compiled. The bigger change here is to fix the mempool limit test. The test is failing because the block size increase has made it more difficult for this test to evict a transaction from the mempool. Now, instead of 90 transactions with a 5MB max-mempool we have 270 transactions and a 9MB max-mempool-size. This was tested by manually adding the number of transactions until the txid was evicted from the mempool. Also added nonces to the miner_tests (unit test).