Skip to content

Conversation

@blondfrogs
Copy link
Contributor

No description provided.

@blondfrogs blondfrogs changed the title Ability to Create Sub Assets. Fix large Asset Transactions Ability to Create Sub Assets via RPC. Fix large Asset Transactions Aug 8, 2018
@blondfrogs blondfrogs requested a review from cfox August 8, 2018 16:57

UniValue issuesubasset(const JSONRPCRequest& request)
{
if (request.fHelp || !AreAssetsDeployed() || request.params.size() < 2 || request.params.size() > 8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be <3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep.


UniValue issuesubasset(const JSONRPCRequest& request)
{
if (request.fHelp || !AreAssetsDeployed() || request.params.size() < 2 || request.params.size() > 9)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be < 3 ?

vSolutionsRet.push_back(hashBytes);
return true;
}
// if (scriptPubKey.IsNewAsset()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blondfrogs blondfrogs merged commit ed0ea50 into develop2 Aug 8, 2018
@blondfrogs blondfrogs deleted the sub_asset_2 branch August 17, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants