Add -fPIC as default on Linux builds fixing build errors. Add NONCE to miner_tests #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional NONCE for miner tests.
Collaborator
|
I don't think this should be included. the reason fpic flags are required is due to the gcc version, on many linux versions having an issue with the crypto headers. this is resolved in gcc 7 and why fpic flags are not needed when compiling and cross compiling on ubuntu bionic, as the build-essentials package pulls in gcc 7, whereas other distros do not. gcc 4.x versions seem to have the issue. |
Collaborator
|
also the |
blondfrogs
approved these changes
Aug 3, 2018
|
Someone missed a chapter in -fpic at school! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux the builds it is required to use the -fPIC flag to compile. It is documented as such, but many people overlook it and report it as a build problem. This change makes it so that fPIC is enabled by default on Linux which should resolve this from being reported as a bug.
Also adding additional NONCE to the miner_tests for more robust testing.