Skip to content

Conversation

@BenHenning
Copy link
Collaborator

@BenHenning BenHenning commented Apr 30, 2025

This is a cherry-pick of #8811 into the v12 release branch.

The basics

(ish--largely relying on the original testing for this PR since it's actions-related)

The details

Resolves

This fixes the same issue as #8811 but on the v12 branch.

Proposed Changes

See #8811.

Reason for Changes

The failing assignee workflow will continue on v12 so the cherry-pick makes the next couple of PRs for this branch a bit nicer, but it's not a strong must-have since we'll eventually merge develop into v12 which would then include #8811.

Test Coverage

N/A -- There's no strong benefit from automated tests for this workflow, and it was manually tested as part of #8811 (see #8811 (comment)).

Documentation

N/A -- No documentation changes are needed for this.

Additional Information

None.

* chore: Try another workflow permission.

* chore: Explicitly specify the GitHub token.

* chore: Try with contents: write.

* chore: Try write-all at the top level.

* chore: try regular pull_request.

* chore: Fix assign reviewers action configuration.
@BenHenning BenHenning changed the base branch from develop to rc/v12.0.0 April 30, 2025 17:40
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Apr 30, 2025
@google-cla
Copy link

google-cla bot commented Apr 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator Author

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed to verify parity with #8811.

@BenHenning BenHenning marked this pull request as ready for review April 30, 2025 17:42
@BenHenning BenHenning requested a review from a team as a code owner April 30, 2025 17:42
@BenHenning BenHenning requested a review from cpcallen April 30, 2025 17:42
@BenHenning
Copy link
Collaborator Author

NB: As with #8811, the assignee workflow won't be fixed until after this PR is merged.

@BenHenning
Copy link
Collaborator Author

PTAL @cpcallen.

@BenHenning
Copy link
Collaborator Author

Given that we will actually include #8811 when develop gets merged in, I think it may make sense to ignore this PR but I defer to your choice on that @cpcallen.

@BenHenning
Copy link
Collaborator Author

Thanks @cpcallen. Since this is a small win and generally negligible, will go ahead and merge.

@BenHenning BenHenning merged commit b8c2b73 into RaspberryPiFoundation:rc/v12.0.0 Apr 30, 2025
7 of 10 checks passed
@BenHenning BenHenning deleted the update-workflow-permissions-for-v12 branch April 30, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants