Skip to content

fix: Add some missing message strings. #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 2 commits into from
Apr 21, 2025
Merged

fix: Add some missing message strings. #8908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5852148
fix: Add some missing message strings.
gonfunko Apr 21, 2025
1d101d2
fix: Prefix messages with SHORTCUTS
gonfunko Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions msg/json/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@metadata": {
"author": "Ellen Spertus <ellen.spertus@gmail.com>",
"lastupdated": "2025-04-21 08:25:34.842680",
"lastupdated": "2025-04-21 10:30:50.781430",
"locale": "en",
"messagedocumentation" : "qqq"
},
Expand Down Expand Up @@ -425,5 +425,8 @@
"CUT_SHORTCUT": "Cut (%1)",
"COPY_SHORTCUT": "Copy (%1)",
"PASTE_SHORTCUT": "Paste (%1)",
"HELP_PROMPT": "Press %1 for help on keyboard controls"
"HELP_PROMPT": "Press %1 for help on keyboard controls",
"GENERAL": "General",
Comment thread
gonfunko marked this conversation as resolved.
Outdated
"EDITING": "Editing",
"CODE_NAVIGATION": "Code navigation"
}
5 changes: 4 additions & 1 deletion msg/json/qqq.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,5 +431,8 @@
"CUT_SHORTCUT": "menu label - Contextual menu item that cuts the focused item.",
"COPY_SHORTCUT": "menu label - Contextual menu item that copies the focused item.",
"PASTE_SHORTCUT": "menu label - Contextual menu item that pastes the previously copied item.",
"HELP_PROMPT": "Alert message shown to prompt users to review available keyboard shortcuts."
"HELP_PROMPT": "Alert message shown to prompt users to review available keyboard shortcuts.",
"GENERAL": "shortcut list section header - Label for general purpose keyboard shortcuts.",
"EDITING": "shortcut list section header - Label for keyboard shortcuts related to editing a workspace.",
"CODE_NAVIGATION": "shortcut list section header - Label for keyboard shortcuts related to moving around the workspace."
}
13 changes: 12 additions & 1 deletion msg/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,4 +1720,15 @@ Blockly.Msg.COPY_SHORTCUT = 'Copy (%1)';
Blockly.Msg.PASTE_SHORTCUT = 'Paste (%1)';
/** @type {string} */
/// Alert message shown to prompt users to review available keyboard shortcuts.
Blockly.Msg.HELP_PROMPT = 'Press %1 for help on keyboard controls';
Blockly.Msg.HELP_PROMPT = 'Press %1 for help on keyboard controls';
/** @type {string} */
/// shortcut list section header - Label for general purpose keyboard shortcuts.
Blockly.Msg.GENERAL = 'General';
/** @type {string} */
/// shortcut list section header - Label for keyboard shortcuts related to
/// editing a workspace.
Blockly.Msg.EDITING = 'Editing'
/** @type {string} */
/// shortcut list section header - Label for keyboard shortcuts related to
/// moving around the workspace.
Blockly.Msg.CODE_NAVIGATION = 'Code navigation';