fix: Create CSS vars for SVG patterns. #8671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
Nov 26, 2024
Contributor
|
I think this also fixes #1403? |
Contributor
Author
Depends on what they wanted to do to the disabled pattern. I wouldn't close that yet without putting some thought into it. |
1 task
This was referenced Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8272
We'll need a related PR in blockly-samples that adapts the screenshot plugin to be aware of CSS vars.
Proposed Changes
Adds CSS variables scoped to the injection div referencing the SVG pattern ids so that CSS can use these consistent variable names instead of the random ids that were previously assigned to SVG attributes.
Reason for Changes
So that renderer CSS can customize and override how SVG patterns are used.
Test Coverage
I did not create any new tests, but all existing tests pass and I manually tested that the filters appear to be rendering correctly.
Documentation
N/A
Additional Information
N/A