feat!: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField #8475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Adityajaiswal03
changed the title
github-actions
bot
added
PR: feature
Adityajaiswal03
changed the title
github-actions
bot
added
PR: feature
Adityajaiswal03
changed the title
github-actions
bot
added
PR: feature
Adityajaiswal03
changed the title
github-actions
bot
added
PR: feature
…onEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers.
Adityajaiswal03
force-pushed
the
RenamedBranch
branch
from
ff587bc to
337706e
Compare
Contributor
Author
|
Hi @BeksOmega, I’ve submitted a new PR. Could you please take a look and provide your feedback? |
Contributor
Author
|
@gonfunko |
BeksOmega
changed the title
github-actions
bot
added
breaking change
BeksOmega
approved these changes
Aug 12, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks great =) Once this passes CI I'll get it merged! Thank you for your work on this.
mikeharv
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Apr 2, 2025
mikeharv
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Apr 2, 2025
mikeharv
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Apr 2, 2025
8 tasks
github-actions
bot
added
breaking change
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8290
BREAKING CHANGE
If you used
.blocklyEditableTextor.blocklyNonEditableTextcss classes, update your usages to.blocklyEditableFieldand.blocklyNonEditableFieldinstead.