Skip to content

feat: Add css classes from json block definitions #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeksOmega merged 3 commits into from
Jul 17, 2024
Merged

feat: Add css classes from json block definitions #8377

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e7fb6f
fix: override `jsonInit` method to add css classes
ishon19 Jul 16, 2024
6905d52
fix: lint
ishon19 Jul 16, 2024
b834c1a
refactor: simplify logic
ishon19 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions core/block_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1720,4 +1720,20 @@ export class BlockSvg
traverseJson(json as unknown as {[key: string]: unknown});
return [json];
}

override jsonInit(json: AnyDuringMigration): void {
super.jsonInit(json);

if (json['classes']) {
let classesToAdd = '';

if (Array.isArray(json['classes'])) {
classesToAdd = json['classes'].join(' ');
} else {
classesToAdd = json['classes'];
}

this.addClass(classesToAdd);

@BeksOmega BeksOmega Jul 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can simplify this using a ternary operator.

Suggested change
let classesToAdd = '';
if (Array.isArray(json['classes'])) {
classesToAdd = json['classes'].join(' ');
} else {
classesToAdd = json['classes'];
}
this.addClass(classesToAdd);
this.addClass(Array.isArray(json['classes']) ? json['classes'].join(' ') : json['classes']);

You'll probably need to run npm run format in the root directory after applying this change to handle the line wrapping.

@ishon19 ishon19 Jul 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, thanks for pointing that out! Updated that and formatted using npm run format.

}
}
}