Skip to content

fix!: Rename editing CSS class to blocklyEditing (#8287) #8301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeksOmega merged 2 commits into from
Jul 22, 2024
Merged

fix!: Rename editing CSS class to blocklyEditing (#8287) #8301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b23f74
chore!: Rename editing CSS class to blocklyEditing (#8287)
ga-fleury Jul 11, 2024
c1c86ad
further changes
ga-fleury Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/field_input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export abstract class FieldInput<T extends InputTypes> extends Field<

const clickTarget = this.getClickTarget_();
if (!clickTarget) throw new Error('A click target has not been set.');
dom.addClass(clickTarget, 'editing');
dom.addClass(clickTarget, 'blocklyEditing');

const htmlInput = document.createElement('input');
htmlInput.className = 'blocklyHtmlInput';
Expand Down
2 changes: 1 addition & 1 deletion core/renderers/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ export class ConstantProvider {
`}`,

// Editable field hover.
`${selector} .blocklyEditableText:not(.editing):hover>rect {`,
`${selector} .blocklyEditableText:not(.blocklyEditing):hover>rect {`,
`stroke: #fff;`,
`stroke-width: 2;`,
`}`,
Expand Down
4 changes: 2 additions & 2 deletions core/renderers/zelos/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,9 +825,9 @@ export class ConstantProvider extends BaseConstantProvider {

// Editable field hover.
`${selector} .blocklyDraggable:not(.blocklyDisabled)`,
` .blocklyEditableText:not(.editing):hover>rect,`,
` .blocklyEditableText:not(.blocklyEditing):hover>rect,`,
`${selector} .blocklyDraggable:not(.blocklyDisabled)`,
` .blocklyEditableText:not(.editing):hover>.blocklyPath {`,
` .blocklyEditableText:not(.blocklyEditing):hover>.blocklyPath {`,
`stroke: #fff;`,
`stroke-width: 2;`,
`}`,
Expand Down