Skip to content

fix: correctly report the pre-resize-drag size to workspace comment size change listeners #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 3 commits into from
Jul 2, 2024
Merged

fix: correctly report the pre-resize-drag size to workspace comment size change listeners #8240

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
015f58c
fix: correctly report the pre-resize-drag size to workspace comment s…
gonfunko Jul 2, 2024
12920a5
chore: run formatter
gonfunko Jul 2, 2024
f6d8876
refactor: implicitly use the presence of preResizeSize to identify a …
gonfunko Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/comments/comment_view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ export class CommentView implements IRenderedElement {
/** Whether this comment view has been disposed or not. */
private disposed = false;

/** Size of this comment when the resize drag was initiated. */
private preResizeSize?: Size;

constructor(private readonly workspace: WorkspaceSvg) {
this.svgRoot = dom.createSvgElement(Svg.G, {
'class': 'blocklyComment blocklyEditable',
Expand Down Expand Up @@ -334,8 +337,12 @@ export class CommentView implements IRenderedElement {
* elements to reflect the new size, and triggers size change listeners.
*/
setSize(size: Size) {
const oldSize = this.size;
let oldSize = this.size;
this.setSizeWithoutFiringEvents(size);
if (Size.equals(oldSize, this.size) && this.preResizeSize) {
Comment thread
gonfunko marked this conversation as resolved.
Outdated
oldSize = this.preResizeSize;
this.preResizeSize = undefined;
}
this.onSizeChange(oldSize, this.size);
}

Expand Down Expand Up @@ -519,6 +526,8 @@ export class CommentView implements IRenderedElement {
return;
}

this.preResizeSize = this.getSize();

// TODO(#7926): Move this into a utils file.
this.workspace.startDrag(
e,
Expand Down