Skip to content

fix: Ephemeral focus being taken twice in field-slider and field-angle #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHenning merged 3 commits into from
May 15, 2025
Merged

fix: Ephemeral focus being taken twice in field-slider and field-angle #2521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf62070
fix: Fix ephemeral focus being taken twice.
BenHenning May 14, 2025
310f198
Merge branch 'rc/v12.0.0' into fix-double-ephemeral-focus-issues
BenHenning May 14, 2025
62ca98c
Merge branch 'rc/v12.0.0' into fix-double-ephemeral-focus-issues
BenHenning May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/field-angle/src/field_angle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,13 @@ export class FieldAngle extends Blockly.FieldNumber {
// eslint-disable-next-line @typescript-eslint/naming-convention
protected override showEditor_(e?: Event) {
// Mobile browsers have issues with in-line textareas (focus & keyboards).
// Also, don't let the parent take ephemeral focus since the drop-down div
// below will handle it, instead.
const noFocus =
Blockly.utils.userAgent.MOBILE ||
Blockly.utils.userAgent.ANDROID ||
Blockly.utils.userAgent.IPAD;
super.showEditor_(e, noFocus);
super.showEditor_(e, noFocus, false);

const editor = this.dropdownCreate();
Blockly.DropDownDiv.getContentDiv().appendChild(editor);
Expand Down
5 changes: 3 additions & 2 deletions plugins/field-slider/src/field_slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ export class FieldSlider extends Blockly.FieldNumber {
protected showEditor_(e?: Event, quietInput?: boolean) {
// Always quiet the input for the super constructor, as we don't want to
// focus on the text field, and we don't want to display the modal
// editor on mobile devices.
super.showEditor_(e, true);
// editor on mobile devices. Also, don't let the parent take ephemeral focus
// since the drop-down div below will handle it, instead.
super.showEditor_(e, true, false);

// Build the DOM.
const editor = this.dropdownCreate_();
Expand Down
Loading