fix: Fix scrolling and API issues with the continuous toolbox plugin. #2485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
requested review from
cpcallen and
rachel-fenichel
and removed request for
a team
gonfunko
changed the title
rachel-fenichel
approved these changes
Feb 3, 2025
cpcallen
pushed a commit
to cpcallen/blockly-samples
that referenced
this pull request
May 7, 2025
…RaspberryPiFoundation#2485) * fix: Fix bugs when scrolling between categories. * feat: Readd `getCategoryScrollPosition`. * chore: Placate the linter. * chore: Note units in docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This PR fixes bugs that (1) prevented scrolling the flyout if the first category was clicked, (2) caused jank when scrolling the flyout via the scrollbar and (3) reintroduces the
getCategoryScrollPosition()method, which is used by Scratch.