fix(field-*): Remove unneeded fieldRegistry.unregister calls
#2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
added
category: plugin
cpcallen
requested review from
rachel-fenichel
and removed request for
a team
Collaborator
Collaborator
|
This PR fixes part of #2194. I think you should also fix the other todos so we can close the issue entirely; all are marked with the issue number. |
Collaborator
Author
OK. I did this bit unaware of the cleanup issue because it had come up in the forum as the warnings appear to be causing developer concern. |
Since FieldAngle, FieldColour and FieldMultilineInput are no longer in core, there's no longer any need for their corresponding plugins to unregister the built-in version.
For some reason the last time we ran publish, the publish commit 7d3e23f removed all the trailing newlines from our package-lock.json files. In RaspberryPiFoundation#2453 rachel-fenichel proposes adding these files to our .prettierignore.rc, but for now I'll just fix the files so that the format check passes.
cpcallen
force-pushed
the
fix/plugins-no-unregister
branch
from
087db5b to
d591183
Compare
cpcallen
force-pushed
the
fix/plugins-no-unregister
branch
from
d591183 to
615a08e
Compare
Collaborator
Author
|
OK, the history of this PR is pretty chaotic due to Git-fu (and more particularly GitHub-fu) shortcomings on my part, but the code is now ready for review and now deals with all all remaining instances of |
rachel-fenichel
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Fixes #2194.
Proposed Changes
Remove unneeded
fieldRegistry.unregistercalls fromplugins/field-angle,field-colourandfield-multilineinput's register functions.Also remove the
unregisterBlockstest helper functions, which are no longer needed for similar reasons.Reason for Changes
Since
FieldAngle,FieldColourandFieldMultilineInputare no longer in core, there's no longer any need for their corresponding plugins to unregister the built-in version.