Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add project fingerprint to model metadata #9808

Merged
merged 2 commits into from
Oct 7, 2021
Merged

add project fingerprint to model metadata #9808

merged 2 commits into from
Oct 7, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Oct 6, 2021

@wochinge wochinge requested a review from joejuzl October 6, 2021 14:53
@wochinge wochinge requested a review from a team as a code owner October 6, 2021 14:53
@wochinge wochinge removed the request for review from a team October 6, 2021 14:53
joejuzl
joejuzl approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@joejuzl joejuzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wochinge
Copy link
Contributor Author

wochinge commented Oct 6, 2021

I'll wait with merging as some tests re Agent.load are broken and I'd like to check if the metadata access works as expected

@wochinge wochinge force-pushed the origin/3.0-architecture-revamp/9768/project_fingerprint branch from f4ed45a to 214c398 Compare October 7, 2021 08:12
@wochinge wochinge merged commit e945ff0 into 3.0-architecture-revamp/9604/prediction Oct 7, 2021
@wochinge wochinge deleted the origin/3.0-architecture-revamp/9768/project_fingerprint branch October 7, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejuzl joejuzl joejuzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @joejuzl