Utilizing retrieval intents in test stories #9657
Conversation
jupyterjazz
added
area:rasa-oss 🎡
data/test_retrieval_intents_in_test_stories/tests/test_stories.yml
Outdated
Show resolved
Hide resolved
| intent: chitchat/ask_name | ||
| - action: utter_chitchat/ask_weather | ||
|
|
||
| - story: test 2 - test that works well without retrieval intents 1 |
There was a problem hiding this comment.
shouldn't this one fail due to the wrong utter_goodbye?
There was a problem hiding this comment.
Yes, it does fail. And I'm checking failed_test_stories.yml to see if it failed correctly.
There was a problem hiding this comment.
should we fix the comment then?
| failed_stories_path = response_selector_results / "failed_test_stories.yml" | ||
| failed_stories = read_yaml(read_file(failed_stories_path, "utf-8")) | ||
| # check that the intent is shown correctly in the failed test stories file | ||
| target_intents = { |
There was a problem hiding this comment.
optional: This test is a bit hard to read - could we just create another test file with the expected output and then compare these files?
There was a problem hiding this comment.
You mean having the target dictionaries (target_intents and target_actions) in a file and reading it during the test?
There was a problem hiding this comment.
I meant having a "expected_failed_test_stories.yml" which you can just compare to the failed_test_stories.yml` from these tests by comparing the strings instead of doing the workarounds you're currently doing
PR for issue #8459
Proposed changes:
Status (please check what you already did):
- [ ] updated the documentationblack(please check Readme for instructions)