Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dense features and CRFEntityExtractor - docs update #9572

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Dense features and CRFEntityExtractor - docs update #9572

merged 6 commits into from
Sep 17, 2021

Conversation

tttthomasssss
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

erohmensing
erohmensing approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖️

koernerfelicia
koernerfelicia approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@koernerfelicia koernerfelicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I dropped the ball on this one -.- Feel free to poke me in future if I don't respond to a review request like this

@tttthomasssss tttthomasssss merged commit 954107f into main Sep 17, 2021
@tttthomasssss tttthomasssss deleted the issue-8930 branch September 17, 2021 19:49
@tttthomasssss tttthomasssss mentioned this pull request Sep 17, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@koernerfelicia koernerfelicia koernerfelicia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tttthomasssss @erohmensing @koernerfelicia