Add repr to Token - Related to Issue #7250, PR #7839 #9543

ErickGiffoni · 2021-09-06T13:35:19Z

Issue #7250 was previously solved via PR #7839 but there was some trouble during the checks.
The conversation in the PR 7839 ended, so I continued the work.

Proposed changes:

Fixes a typo warned by the typo CI

Status (please check what you already did):

added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

ancalita · 2021-09-06T14:08:36Z

Hi @ErickGiffoni Thank you for looking into this 🚀
Since the branch issue-7250 is quite outdated, I'd recommend starting from scratch and have your new PR target main branch to close this issue. Once you've done that, this PR should be closed.

ErickGiffoni · 2021-09-06T19:04:17Z

Hi @ErickGiffoni Thank you for looking into this 🚀
Since the branch issue-7250 is quite outdated, I'd recommend starting from scratch and have your new PR target main branch to close this issue. Once you've done that, this PR should be closed.

Ok, no problem !

Would it be ok if I just change this PR's base branch to "main", since I've merged both branches ?
I see that this PR has got filled with too many files to review lol but that's probably because of the merging
with main and the target being issue-7250 as you pointed out.

ancalita · 2021-09-07T07:06:10Z

Would it be ok if I just change this PR's base branch to "main"

@ErickGiffoni Sure, as long as your changes/ commits become visible for review.

ErickGiffoni · 2021-09-07T18:57:57Z

@ancalita done. Thanks for reviewing this ! I'll be awaiting for further feedback.

aeshky · 2021-09-08T13:07:17Z

Thanks for your contribution, @ErickGiffoni.
Can you please add a change log file (the instructions here). Also, can you target the 2.8.x branch instead of main?

ErickGiffoni · 2021-09-08T13:17:51Z

Thanks for your contribution, @ErickGiffoni.
Can you please add a change log file (the instructions here). Also, can you target the 2.8.x branch instead of main?

Yeah, sure, as you wish ! I’ll do it as soon as possible, thanks.

ErickGiffoni · 2021-09-08T21:10:32Z

Thanks for your contribution, @ErickGiffoni.
Can you please add a change log file (the instructions here). Also, can you target the 2.8.x branch instead of main?

@aeshky Done! I did what you asked me to do. First the change log file. But when changing the target branch, lots of new files were changed. Is it ok or should I do differently ?
Also, now there are 2 conflicts, what should we do ?

aeshky · 2021-09-09T06:57:45Z

Thanks for making the changes @ErickGiffoni. I should have been clearer: can you rebase your branch on 2.8.x and then target it for the merge? That way your change gets released in the next micro release instead of waiting for the next major release. So the only difference should be your changes.

Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.6.0 to 0.9.1. - [Release notes](https://github.com/styfle/cancel-workflow-action/releases) - [Commits](styfle/cancel-workflow-action@0.6.0...a40b884) --- updated-dependencies: - dependency-name: styfle/cancel-workflow-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Implement core graph parts and runner.

CachedComponent Co-authored-by: Tobias Wochinger <[email protected]>

* Add ability to point to a certificate in endpoints.yml (RasaHQ#9118) * Add cert file functionality to Endpoint * Apply suggestions from code review types Co-authored-by: Tobias Wochinger <[email protected]> * update changelog Co-authored-by: Tobias Wochinger <[email protected]> * Fix epoch override for TEDPolicy (RasaHQ#9182) * bump rasa-sdk dep and min compat version * fix bug add tests * add changelog * change test cases * remove test cases * prepared release of version 2.8.1 (RasaHQ#9183) * update rasa-sdk * prepared release of version 2.8.1 * update lock * Make UnexpecTEDIntentPolicy compatible with E2E data (RasaHQ#9203) * bump rasa-sdk dep and min compat version * add test and code * add changelog and refactor method * add test * more test cases * use applied_events * 2.8.x: Remove experimental feature warning for story validation and entity roles and groups (RasaHQ#9237) * I removed the experimental feature designation from the docs. * I removed the entity roles and groups experimental feature warning message from the code, and tested it using 'rasa train' on a minimal example. * I removed the unused import: rasa.shared.utils.common * Adding change log files for issues 8791 and 8024. * Rewording change logs to make it clear that the behaviour of the features remains unchanged. * prepared release of version 2.8.2 (RasaHQ#9262) * prepared release of version 2.8.2 * Updated the date of release. * install yarn dependency in cloned repository, in docs publication workflow * silence yarn warning * Fix typo in push_docs_to_branch.sh * Generated a new poetry lock file Co-authored-by: Joe Juzl <[email protected]> Co-authored-by: Tobias Wochinger <[email protected]> Co-authored-by: Daksh Varshneya <[email protected]> Co-authored-by: m-vdb <[email protected]>

* update-toml * added-changelog * poetry-lock * update-lock-file-again

Bumps [pydoc-markdown](https://github.com/NiklasRosenstein/pydoc-markdown) from 3.13.0 to 4.1.6. - [Release notes](https://github.com/NiklasRosenstein/pydoc-markdown/releases) - [Commits](NiklasRosenstein/pydoc-markdown@v3.13.0...v4.1.6) --- updated-dependencies: - dependency-name: pydoc-markdown dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [regex](https://bitbucket.org/mrabarnett/mrab-regex) from 2021.7.6 to 2021.8.28. - [Commits](https://bitbucket.org/mrabarnett/mrab-regex/commits) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [moto](https://github.com/spulec/moto) from 2.0.11 to 2.2.6. - [Release notes](https://github.com/spulec/moto/releases) - [Changelog](https://github.com/spulec/moto/blob/master/CHANGELOG.md) - [Commits](getmoto/moto@2.0.11...2.2.6) --- updated-dependencies: - dependency-name: moto dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

In light of the fact the predictions list can only contain 0 or 1 messages, we don't need a test that tests for 2 messages. Also, drop setting metadata in the Message as that is now carried over through the original UserMessage which is not parameterised

ErickGiffoni · 2021-09-09T14:11:35Z

Thanks for making the changes @ErickGiffoni. I should have been clearer: can you rebase your branch on 2.8.x and then target it for the merge? That way your change gets released in the next micro release instead of waiting for the next major release. So the only difference should be your changes.

@aeshky Ok, done it ! I never solved soo many conflicts in my life ( lol ).

I rebased it like this: git pull --rebase upstream 2.8.x, where "upstream" is set to here, RasaHQ/rasa.

Obs.: from the beginning my current branch was always issue-7250

Then, after solving lots of conflicts, I tried to git push origin issue-7250 (my origin is set to my repository), but it says my current branch is behind the remote one. Maybe makes sense, since initially my branch issue-7250 was created from branch main.

But now it is rebased, so it's like it was created from 2.8.x which is probably behind main.
My point is that I am so confused right now that I need help, lol. I'm sorry.

What should I do ?

Should I just git push -f origin issue-7250 ?

Found this reference on Stack Overflow, it is exactly my problem: https://stackoverflow.com/questions/8939977/git-push-rejected-after-feature-branch-rebase .

aeshky · 2021-09-14T09:15:30Z

Hey @ErickGiffoni. Sorry you had to resolve so many conflicts! Your original submission only had changes to a couple of files, but it looks like rebasing your branch on 2.8.x created too many conflicts.

I think the easiest way to resolve this is to create a new branch from 2.8.x, then move your commits to it (using git cherry-pick). You can then create a new pull request and tag me in it. How does that sound?

ErickGiffoni · 2021-09-14T12:36:37Z

Hey, @aeshky, ok that sounds good for me, I'm on it. Looking forward to have my contribution accepted !

ErickGiffoni · 2021-09-14T13:35:56Z

New PR created: #9631

Closing this one !

ErickGiffoni requested a review from a team as a code owner September 6, 2021 13:35

ErickGiffoni requested review from ancalita and removed request for a team September 6, 2021 13:35

ErickGiffoni mentioned this pull request Sep 6, 2021

Sprint 3 FGA-GCES/rasa#120

Closed

ErickGiffoni changed the base branch from issue-7250 to main September 7, 2021 18:45

ErickGiffoni requested review from a team and aeshky and removed request for a team September 7, 2021 18:45

ErickGiffoni changed the base branch from main to 2.8.x September 8, 2021 21:07

dependabot bot and others added 13 commits September 9, 2021 10:12

Implement core graph entities and runner (RasaHQ#9224)

d222061

Implement core graph parts and runner.

implement ModelStorage (RasaHQ#9233)

bbe4739

Add changelog entry.

3fd2fe5

implement Cache (RasaHQ#9234)

921f096

Training hooks (RasaHQ#9257)

fa1ccd0

CachedComponent (RasaHQ#9261)

e85acb8

CachedComponent Co-authored-by: Tobias Wochinger <[email protected]>

prepared release of version 2.7.2

ff7c36d

Upgrade to spaCy 3.1 (RasaHQ#9284)

8a61c4c

* update-toml * added-changelog * poetry-lock * update-lock-file-again

implement graph schema validation

b0382c9

disable dependabot updates for docs theme

71e63dc

wochinge and others added 21 commits September 9, 2021 10:39

duplicate DucklingEntityExtractor to prepare for adaption

29c5663

Update component with PR feedback

0c7b3ca

Add tests

4660cd9

migrate DucklingEntityExtractor

40fb874

address review comments

7de7fa4

fix unit test

2f4571e

extract component creation

b240cdc

amend test

d33fffc

remove assertion

d9a8116

Address PR comments

1fd2291

Update tests to make less tautological

f707a40

Address PR comments

7561f42

Add freezegun to permit comparison of events

8e7c0e0

address review comments

3a9f4ef

Migrate SpacyEntityExtractor for the graph. (RasaHQ#9571)

faea8f7

regex entity extractor (RasaHQ#9552)

3b9c1b3

make some review tweaks

5eeac68

adds the changelog related to issue RasaHQ#7250

2720d89

ErickGiffoni force-pushed the issue-7250 branch from 29296b5 to 2720d89 Compare September 9, 2021 22:15

ErickGiffoni mentioned this pull request Sep 14, 2021

Adds __repr__ method to Token - Fixes issue 7250 #9631

Merged

4 tasks

ErickGiffoni closed this Sep 14, 2021

ErickGiffoni mentioned this pull request Sep 14, 2021

Sprint 4 - 2021/1 FGA-GCES/rasa#130

Closed

SamuelNoB deleted the issue-7250 branch January 27, 2022 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add repr to Token - Related to Issue #7250, PR #7839 #9543

Add repr to Token - Related to Issue #7250, PR #7839 #9543

ErickGiffoni commented Sep 6, 2021 •

edited

Loading

ancalita commented Sep 6, 2021

ErickGiffoni commented Sep 6, 2021 •

edited

Loading

ancalita commented Sep 7, 2021

ErickGiffoni commented Sep 7, 2021

aeshky commented Sep 8, 2021

ErickGiffoni commented Sep 8, 2021

ErickGiffoni commented Sep 8, 2021 •

edited

Loading

aeshky commented Sep 9, 2021

ErickGiffoni commented Sep 9, 2021 •

edited

Loading

aeshky commented Sep 14, 2021

ErickGiffoni commented Sep 14, 2021

ErickGiffoni commented Sep 14, 2021

Add __repr__ to Token - Related to Issue #7250, PR #7839 #9543

Add __repr__ to Token - Related to Issue #7250, PR #7839 #9543

Conversation

ErickGiffoni commented Sep 6, 2021 • edited Loading

ancalita commented Sep 6, 2021

ErickGiffoni commented Sep 6, 2021 • edited Loading

ancalita commented Sep 7, 2021

ErickGiffoni commented Sep 7, 2021

aeshky commented Sep 8, 2021

ErickGiffoni commented Sep 8, 2021

ErickGiffoni commented Sep 8, 2021 • edited Loading

aeshky commented Sep 9, 2021

ErickGiffoni commented Sep 9, 2021 • edited Loading

aeshky commented Sep 14, 2021

ErickGiffoni commented Sep 14, 2021

ErickGiffoni commented Sep 14, 2021

Add repr to Token - Related to Issue #7250, PR #7839 #9543

Add repr to Token - Related to Issue #7250, PR #7839 #9543

ErickGiffoni commented Sep 6, 2021 •

edited

Loading

ErickGiffoni commented Sep 6, 2021 •

edited

Loading

ErickGiffoni commented Sep 8, 2021 •

edited

Loading

ErickGiffoni commented Sep 9, 2021 •

edited

Loading