Increase the timeout to run tests/test_server.py::assert_trained_model test successfully on Windows
#8781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el` test successfully on Windows
ancalita
reviewed
Jun 1, 2021
tests/test_server.py
Outdated
| @@ -537,7 +538,7 @@ async def test_train_core_success_with( | |||
| assert os.path.exists(os.path.join(model_path, "fingerprint.json")) | |||
|
|
|||
|
|
|||
| async def test_train_with_retrieval_events_success( | |||
There was a problem hiding this comment.
Why did you edit the original test name? The name is now a duplicate of the test below that gets called in this test body.
There was a problem hiding this comment.
Oops, this is a mistake. Fixed it.
ancalita
reviewed
Jun 1, 2021
changelog/8658.misc.md
Outdated
| @@ -0,0 +1 @@ | |||
| Increase the timeout to run `tests/test_server.py::assert_trained_model` test successfully on Windows. | |||
There was a problem hiding this comment.
This could be nitpicking now - shouldn't the name of the test in the changelog also change? 😄
There was a problem hiding this comment.
This is so stupid that the test name has somehow changed 🙈 Probably my mind was occupied with something else at this point.
There was a problem hiding this comment.
Fixed now. Sorry for spending your time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
The reason for this change: it sometimes takes longer to run the training process on Windows (everything is a bit slower on Windows GH runners), and that's why the test for
tests/test_server.py::assert_trained_modelis sometimes flakey. This change fixes it.Status (please check what you already did):
black(please check Readme for instructions)