Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter import fix #8742

Merged
merged 3 commits into from
May 25, 2021
Merged

Jupyter import fix #8742

merged 3 commits into from
May 25, 2021

Conversation

desmarchris
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@desmarchris desmarchris requested a review from wochinge May 25, 2021 14:46
wochinge
wochinge approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you please also add a changelog entry?

@desmarchris desmarchris merged commit 2da0007 into 2.6.x May 25, 2021
@desmarchris desmarchris deleted the jupyter-fix branch May 25, 2021 20:29
@ancalita ancalita mentioned this pull request Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desmarchris @wochinge