Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non expressive variable names on rasa/shared/core/events.py #8530

Closed

Conversation

joaoCeilandia
Copy link
Contributor

Proposed changes:

  • Change variable names on rasa/shared/core/events.py

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger sara-tagger requested a review from lty4 April 23, 2021 06:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @lty4 will take a look at it as soon as possible ✨

@ErickGiffoni ErickGiffoni deleted the aplying-clean-code-to-files branch August 5, 2021 19:42
@stale
Copy link

stale bot commented Apr 16, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@ancalita
Copy link
Member

@joaoCeilandia I can see that the development branch was deleted 10 months ago. As a result, I will close this PR.
If you wish to contribute further, please open a new PR.

@ancalita ancalita closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants