Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes character appear as " in the docs #8392

Closed
wants to merge 580 commits into from

Conversation

jppgomes
Copy link
Contributor

@jppgomes jppgomes commented Apr 8, 2021

Co-authored-by: erico [email protected]

Proposed changes:

issue #8288

In the docs, in the format_message function, quotes appear as " as shown below :
I am from [Berlin]{"entity": "city"}.
which corresponds to this code where quotes appear ok.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@netlify
Copy link

netlify bot commented Apr 8, 2021

‼️ Deploy request for rasahq-docs-rasa-v2 rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: 79d2bf1

@sara-tagger sara-tagger requested a review from indam23 April 8, 2021 12:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @melindaloubser1 will take a look at it as soon as possible ✨

Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@indam23
Copy link
Contributor

indam23 commented Apr 12, 2021

Ope, I think you want to base it off of another branch though, probably main. That branch is for auto-doc things I'm pretty sure.

@indam23 indam23 changed the base branch from documentation to main April 12, 2021 13:23
@indam23 indam23 closed this Apr 12, 2021
@indam23
Copy link
Contributor

indam23 commented Apr 12, 2021

My bad, didn't mean to close the PR 🙈 seems it happens automatically

@indam23
Copy link
Contributor

indam23 commented Apr 12, 2021

Can you please reopen the PR, but based on main?

@jppgomes
Copy link
Contributor Author

@melindaloubser1 Okay, I'll do this

@ericoBandeira ericoBandeira mentioned this pull request Apr 20, 2021
4 tasks
@ErickGiffoni ErickGiffoni deleted the 8288/Quotescharacter branch August 5, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants