Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7005 rasa interactive cannot write non ascii character #8358

Conversation

joaoCeilandia
Copy link
Contributor

@joaoCeilandia joaoCeilandia commented Apr 1, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @desmarchris will take a look at it as soon as possible ✨

@HotThoughts
Copy link
Contributor

Hey, the failing step wait for doc tests in CI workflow has fixed. The PR should be ready to review when the fix merged into your PR. 😊

@HotThoughts
Copy link
Contributor

Seems like the fix does not work with the situation when updating from the base branch I will fix this soon!

@HotThoughts
Copy link
Contributor

👋 Hey, the error is fixed. Please update the branch.

@joaoCeilandia
Copy link
Contributor Author

Thanks! @HotThoughts

@HotThoughts
Copy link
Contributor

@RasaHQ/enable-squad maybe one of you can review this PR?

@twerkmeister twerkmeister self-requested a review April 13, 2021 11:31
@twerkmeister
Copy link
Contributor

twerkmeister commented Apr 13, 2021

@HotThoughts will look into it! I am working on another issue with interactive mode and non-ascii characters anyway

Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, good find and thanks for taking the initative on this one 👍 ! Just added small suggestions that you can use directly.

changelog/7005.bugfix.md Outdated Show resolved Hide resolved
rasa/core/training/interactive.py Outdated Show resolved Hide resolved
joaoCeilandia and others added 2 commits May 2, 2021 16:49
Co-authored-by: Thomas Werkmeister <[email protected]>
@joaoCeilandia
Copy link
Contributor Author

Thanks for the feedback @twerkmeister !

Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@twerkmeister twerkmeister merged commit 329aa10 into RasaHQ:main May 3, 2021
@ErickGiffoni ErickGiffoni deleted the 7005-rasa-interactive-cannot-write-non-ascii-character branch August 5, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rasa interactive cannot write non-ascii character due to the encoing
4 participants