Add function to carry max_history to featurizer #8292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marcelo Araújo <[email protected]> Co-authored-by: Rafael Teodosio <[email protected]> Co-authored-by: ericoBandeira <[email protected]> Co-authored-by: Joao Pedro Gomes <[email protected]>
|
Thanks for submitting a pull request 🚀 @TyDunn will take a look at it as soon as possible ✨ |
Ghostvv
reviewed
Mar 25, 2021
change the way to carry max_history to featurizer Co-authored-by: Vladimir Vlasov <[email protected]>
remove unused function in the solution
Ghostvv
approved these changes
Mar 25, 2021
|
@Ghostvv sorry for requiring that much from you but do you face that fail before? Could you give me a hint? |
|
@wochinge do you have an idea why docs test is failing? |
Hey @joaoCeilandia and @Ghostvv, the docs test just fixed! When you merge the main branch into this PR, the docs test should be green. |
|
@Ghostvv do you know if this file has been modified or updated to a new version in the current rasa version? If not, do you know how to solve this? |
|
@Ghostvv the failing test disappeared, it's abble to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
max-historyto featurizerStatus (please check what you already did):
black(please check Readme for instructions)