_utter_responses should handle template and response
#8226
Conversation
yennycheung
requested review from
a team and
wochinge
and removed request for
a team
|
@wochinge, I want to ask for your opinion here. I think we should still make the sdk change now, so that the deprecation message would make sense. Any dependencies I need to be aware of? If we push the sdk change first, it'll also make sense to update these https://github.com/RasaHQ/rasa/blob/main/examples/formbot/actions/actions.py#L51 |
There was a problem hiding this comment.
I want to ask for your opinion here. I think we should still make the sdk change now, so that the deprecation message would make sense. Any dependencies I need to be aware of? If we push the sdk change first, it'll also make sense to update these
I agree somewhat. My reasoning behind doing Rasa Open Source first was that this bug blocks users right now while a weird deprecation message isn't blocking for users.
I'd make the SDK send both (template + response) keys for now to make the new SDK version keeps on working with older Rasa Open Source versions.
Depends all a bit on your time. I can do the SDK change tomorrow morning to support you?
|
@wochinge, I looked into the SDK, but I got some questions, I'll ping you tomorrow. :) |
rasa/core/actions/action.py
Outdated
| if not generated_response: | ||
| generated_response = response.pop("template", None) | ||
| rasa.shared.utils.io.raise_deprecation_warning( | ||
| "The terminology 'template' is deprecated and replaced by 'response', use the `response` parameter instead of `template` in the dispatcher.", |
There was a problem hiding this comment.
How about making this warning more actionable? E.g. upgrading to Rasa SDK xy or adapting their custom SDK?
There was a problem hiding this comment.
@yennycheung Can you please rebase this to be merged into 2.4.x? We need to cut a micro release with this change and this can only be done from 2.4.x
Proposed changes:
_utter_responsesshould handletemplateandresponsedispatcher.utter_message(template=...)no longer works in a custom action #8223Status (please check what you already did):
black(please check Readme for instructions)Manual testing
I tested this on formbot. Before, formbot wasn't able to respond with
utter_wrong_num_people. After the change, it was able to.