Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raising exception when having empty intent or entity mapping in the domain #8222

Merged
merged 8 commits into from
Mar 25, 2021
Merged

Raising exception when having empty intent or entity mapping in the domain #8222

merged 8 commits into from
Mar 25, 2021

Commits on Mar 17, 2021

  1. Added an InvalidDomain exception when having an empty intent mapping

    Imod7 committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    4505282 View commit details
    Browse the repository at this point in the history

  2. Changes while checking the intent mapping & new test 

    - Replaced try/except statement with if/else when checking if intent mapping is empty.
- Minor rewording on the exception message.
- Added a new test to check if the exception is correctly raised.
    Imod7 committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    be336d9 View commit details
    Browse the repository at this point in the history

  3. Added a changelog

    Imod7 committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    fec8a87 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Rewordings 

    - Rewording of the function's docstring.
- Rewording of the InvalidDomain exception message.
    Imod7 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    7df9f05 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Handling also empty entity mapping 

    - Added a check to handle also empty entity mapping.
- Changed the changelog.
- Added a test for the empty entity mapping.
    Imod7 committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    757c3fa View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Merge branch 'main' into empty_intent_mapping_in_domain

    Dominique authored Mar 24, 2021
    Configuration menu
    Copy the full SHA
    20eb560 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Merge branch 'main' into empty_intent_mapping_in_domain

    Dominique authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    644a217 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into empty_intent_mapping_in_domain

    Dominique authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    3b228f8 View commit details
    Browse the repository at this point in the history