-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loockup table validation #8168
Conversation
Support server list, drop group_id from producer
Backport Multiple Sanic Workers fix for 1.10.x
External Message Entity Auto-Filling Fix
Fix v1 docs noindex header
Prepared Release of Version 1.10.21
Backport of aio-pika implementation to 1.10.X
Prepare release 1.10.22
Added Locking Mechanism to Reminders Handler
Update the _add_lookup_table_regexes function to return bool and verify if there was some table in the training data.loockup_tables
Thanks for submitting a pull request 🚀 @yennycheung will take a look at it as soon as possible ✨ |
Thank you for your contribution @iurisevero. The solution looks great. Would you mind pointing the pull request to |
Hi @yennycheung, I'll change the pointing, no problem! But I don't think the CI will accept my changes, because I did them from the tag |
Apologies for the late reply, it seems like there are a lot of unrelated changes, would you mind pulling the latest |
Hi. Don't worry. So, I don't think that pulling the latest main is a good idea. As I said, my changes were made for the 1.10.x version, where this issue still relevant. On the 2.x versions it was already solved. My idea was to merge these changes to 1.10.x branch and fix this problem for the next 1.10 tag. |
@wochinge, do we do patches over the older versions or Rasa OSS? |
We only do so if it's crucial. Rasa Open Source 2 is out since more than half a year and I'd highly encourage to switch to it. We unfortunately don't have the capacity to maintain two majors side by side at the moment. |
I get it. I believe this pull request will be closed so, right? |
@iurisevero, thank you for your help on this one. Hope next time we can get your work merged! 🙏🏼 |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)