profile training data loading #7944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
commented
Feb 12, 2021
|
|
||
| @classmethod | ||
| def is_key_in_yaml2(cls, file_path: Union[Text, Path], *keys: Text) -> bool: | ||
| with open(file_path) as f: |
There was a problem hiding this comment.
besides the nesting and the extra function this is actually a clean fix
There was a problem hiding this comment.
(we should obviously also test the colon, e.g. f"{key}:"
wochinge
commented
Feb 12, 2021
rasa/model.py
Outdated
| # FINGERPRINT_PROJECT: project_fingerprint(), | ||
| # FINGERPRINT_NLU_DATA_KEY: nlu_data.fingerprint(), | ||
| # FINGERPRINT_NLU_LABELS_KEY: nlu_data.label_fingerprint(), | ||
| # FINGERPRINT_STORIES_KEY: stories.fingerprint(), |
There was a problem hiding this comment.
dumping all stories to yaml just to get the hash from the string is expensive
wochinge
commented
Feb 12, 2021
rasa/shared/utils/io.py
Outdated
Comment on lines
331
to
333
| # fix_yaml_loader() | ||
|
|
||
| replace_environment_variables() | ||
| # replace_environment_variables() |
There was a problem hiding this comment.
this brought down the reading times with woz from 1h to 3.6 minutes. In my opinion we only need to replace env variables for config files (endpoints.yml, config.yml, credentials.yml, but not for stories / nlu)
wochinge
commented
Feb 12, 2021
rasa/shared/utils/io.py
Outdated
| @@ -328,9 +328,9 @@ def read_yaml(content: Text, reader_type: Union[Text, List[Text]] = "safe") -> A | |||
| Raises: | |||
| ruamel.yaml.parser.ParserError: If there was an error when parsing the YAML. | |||
| """ | |||
| fix_yaml_loader() | |||
| # fix_yaml_loader() | |||
There was a problem hiding this comment.
no idea if we still need this. It's ancient.
wochinge
force-pushed
the
training-data-loading-tests
branch
from
7b4ef39
to
66ff486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)