Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor feature combining layers in DIET and TED #7589

Merged
merged 144 commits into from
Apr 27, 2021
Merged

Refactor feature combining layers in DIET and TED #7589

Show file tree
Hide file tree
Changes from 70 commits
Commits
Show all changes
144 commits
Select commit Hold shift + click to select a range
83c2a07
Port all refactoring changes from branch e2e-feature-combining-layers…
samsucik Dec 17, 2020
3eca5aa
Add e2ebot with forms, entities and slots.
samsucik Dec 17, 2020
4ba9505
Reformat code.
samsucik Dec 17, 2020
86e98ae
Merge branch 'master' of github.com:RasaHQ/rasa into e2e-feature-comb…
samsucik Dec 17, 2020
c309bd2
Remove unused code and move new layers into rasa_layers.py.
samsucik Dec 18, 2020
d6e9b1a
Merge branch 'master' of github.com:RasaHQ/rasa into e2e-feature-comb…
samsucik Jan 12, 2021
4325939
Merge branch '2.2.x' of github.com:RasaHQ/rasa into e2e-feature-combi…
samsucik Jan 12, 2021
a26a5b0
Make small changes based on review comments.
samsucik Jan 12, 2021
d611e44
Fix Keras errors in DIET.
samsucik Jan 15, 2021
042ae44
Merge branch 'master' of github.com:RasaHQ/rasa into e2e-feature-comb…
samsucik Jan 15, 2021
e121026
Hard-code training of DIET and TED to use eager mode (to see which te…
samsucik Jan 18, 2021
ec94f93
Add step to clear poetry cache
Jan 18, 2021
722d682
Clear poetry cache before a virtual env is created
Jan 18, 2021
23eeab0
Don't use force for rm - windows
Jan 18, 2021
ab59e94
Refactor rasa_layers to consume all inputs in single arg.
samsucik Jan 19, 2021
c8fc276
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Jan 19, 2021
ac449e0
Resolve merge conflicts.
samsucik Jan 19, 2021
ac51434
Disable eager training of TED.
samsucik Jan 19, 2021
141975b
Fix a trivial mistake in DIET.
samsucik Jan 20, 2021
7b43329
Merge branch 'master' of github.com:RasaHQ/rasa into e2e-feature-comb…
samsucik Jan 20, 2021
74587a3
Check differences in results between refactored DIET and the master v…
samsucik Jan 21, 2021
c655042
Merge branch 'master' of github.com:RasaHQ/rasa into e2e-feature-comb…
samsucik Jan 21, 2021
62a1307
Polish up and document the ConcatenateSparseDenseFeatures class.
samsucik Jan 21, 2021
dd4ad18
Fix a fatal typo.
samsucik Jan 22, 2021
9dc3298
Document the ConcatenateSequenceSentenceFeatures custom layer.
samsucik Jan 27, 2021
661d9a8
Merge from main branch.
samsucik Jan 27, 2021
a3a73fd
Fix typo after refactoring new layers.
samsucik Jan 28, 2021
0690421
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Jan 28, 2021
d8167f7
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Jan 29, 2021
93346d3
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Jan 29, 2021
b5ec82a
Continue adding docstrings, almost finish RasaInputLater.
samsucik Jan 29, 2021
41a84f4
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Jan 29, 2021
3701622
Comment in RasaSequenceLayer and DIET on bits I previously didn't ful…
samsucik Feb 1, 2021
c4c144e
Merge from the main branch.
samsucik Feb 1, 2021
186fd13
Finish documenting all code in rasa_layers.
samsucik Feb 2, 2021
ea3f647
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 2, 2021
aadbaa7
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 3, 2021
482b988
Clean up & document code in refactored parts of TED & DIET.
samsucik Feb 3, 2021
05c842e
Remove unnecessary use of a kwargs dict for just 1 argument.
samsucik Feb 3, 2021
fb7b3b3
Remove e2ebot1.
samsucik Feb 3, 2021
28390a5
Make small changes based on review comments.
samsucik Feb 3, 2021
dd57281
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 3, 2021
ac7ae27
Make changes based on 2nd round of review comments.
samsucik Feb 4, 2021
9ff243a
Change how masks are named; simplify the SeqSent layer.
samsucik Feb 4, 2021
9883b08
Remove None returns from custom layers.
samsucik Feb 4, 2021
caeb07d
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Feb 4, 2021
4044f0d
Fix a test to expect empty numpy array of attention weights when the …
samsucik Feb 4, 2021
8511f16
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Feb 4, 2021
bf4c2b0
Make changes based on 3rd round of review comments.
samsucik Feb 4, 2021
664468a
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 5, 2021
7f747c7
Move all mask computation from DIET and TED into custom layers (docst…
samsucik Feb 5, 2021
4cdcbda
Merge changes to TED (#7867).
samsucik Feb 8, 2021
baf92a1
Make changes based on 4th round of review comments.
samsucik Feb 8, 2021
5a809f3
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 8, 2021
2468f98
Move sequence/sentence feature combining logic into RasaFeatureCombin…
samsucik Feb 9, 2021
b892c20
Document some (but not all) changes in rasa_layers.py.
samsucik Feb 9, 2021
ff8ae7e
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 9, 2021
72ba730
Merge from main and resolve conflicts.
samsucik Feb 10, 2021
8066386
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 10, 2021
a73b8b1
Finish polishing up and commenting the code in rasa_layers.
samsucik Feb 10, 2021
ca8352c
Clean up code in rasa_layers that checks that necessary features are …
samsucik Feb 10, 2021
dfea48d
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 10, 2021
1b33122
Small cleanup and renaming in DIET.
samsucik Feb 10, 2021
a8125fe
Fix typos in code.
samsucik Feb 10, 2021
b848aa0
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Feb 10, 2021
44a12e7
Make changes based on another review. Fix bug in masked LM.
samsucik Feb 11, 2021
ebf8d4f
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 11, 2021
25108e9
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Feb 11, 2021
0aaf264
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Feb 11, 2021
6003dae
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Feb 11, 2021
e659ad7
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 22, 2021
08f9f1e
Update rasa/utils/tensorflow/rasa_layers.py
samsucik Feb 22, 2021
b39f617
Update rasa/utils/tensorflow/rasa_layers.py
samsucik Feb 22, 2021
cb18002
Update rasa/utils/tensorflow/rasa_layers.py
samsucik Feb 22, 2021
c10a479
Update rasa/utils/tensorflow/rasa_layers.py
samsucik Feb 22, 2021
19c07c4
Update rasa/utils/tensorflow/rasa_layers.py
samsucik Feb 22, 2021
d3fc69e
Update rasa/utils/tensorflow/rasa_layers.py
samsucik Feb 22, 2021
6ddfb07
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Feb 22, 2021
6ebf097
React to some more review comments.
samsucik Feb 22, 2021
8b419e9
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 22, 2021
36da29f
Tiny fix in docstrings.
samsucik Feb 22, 2021
4f843ea
Draft changes to ResponseSelector.
samsucik Feb 23, 2021
d81eacc
Factor out some shared functions.
samsucik Feb 24, 2021
808d7f6
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 24, 2021
01c53f6
Add changelog for the masked language modeling bug fix.
samsucik Feb 24, 2021
042d620
Tidy up some unnecessary expanding and squeezing of seq. length tenso…
samsucik Feb 24, 2021
14358bd
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Feb 24, 2021
5afbe2f
Clean up last bits in ResponseSelector, make small fixes in rasa_layers.
samsucik Mar 3, 2021
cc3abff
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Mar 3, 2021
47b0bda
Start writing unit tests for rasa_layers.
samsucik Mar 5, 2021
e49fb6b
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Mar 5, 2021
2843376
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Mar 8, 2021
ff2ef8a
Add tests for exceptions and output shapes of Rasa layers.
samsucik Mar 8, 2021
aaaef4c
Fix broken import.
samsucik Mar 8, 2021
a93e3a1
Catch a bug in RasaSequenceLayer & add sensible checking to the spars…
samsucik Mar 15, 2021
f67c49b
Add further tests for the new rasa layers.
samsucik Mar 15, 2021
fc067fe
Merge from main and fix a small conflict.
samsucik Mar 15, 2021
ffe011f
Finish drafting test cases for the new layers.
samsucik Mar 17, 2021
e8f9a47
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Mar 17, 2021
e11b2d5
Add test case for RasaSequenceLayer outputting made up token ids.
samsucik Mar 17, 2021
70484c6
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 18, 2021
bdd6636
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 19, 2021
63a01c0
Test new model layers both in training and testing mode.
samsucik Mar 19, 2021
62c1770
Change empty attention weights to None and adjust tests accordingly.
samsucik Mar 19, 2021
baf49b4
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Mar 19, 2021
f8ff0b6
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Mar 19, 2021
5df03ee
Check that RasaSequenceLayer doesn't apply MLM at test time.
samsucik Mar 19, 2021
689e50d
Remove (probably) unnecessary TensorFlow flag.
samsucik Mar 19, 2021
8ea2c33
Final pass through the docstrings in new Rasa layers.
samsucik Mar 19, 2021
c86f8a0
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 22, 2021
2340bcb
Convert empty list to None everywhere in predictions[DIAGNOSTIC_DATA].
samsucik Mar 22, 2021
62f8f18
Shorten long lines.
samsucik Mar 22, 2021
824a69f
Add a changelog entry.
samsucik Mar 22, 2021
dc949ee
Add type annotations to new unit tests.
samsucik Mar 22, 2021
e241bf4
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 22, 2021
7fefe8c
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 26, 2021
5fc0149
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 29, 2021
3f2eb9b
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 29, 2021
61dba92
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 29, 2021
55a91f2
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Mar 31, 2021
6b5c9ba
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 6, 2021
1d0f20e
Resolve merge conflicts.
samsucik Apr 8, 2021
1960afe
Type-annotate forgotten function.
samsucik Apr 8, 2021
fe864b6
Make small changes (typing & docstrings) based on review comments.
samsucik Apr 12, 2021
1957519
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Apr 12, 2021
365d0dd
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 12, 2021
4a9687f
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 14, 2021
de665cd
Make small improvements based on review comments.
samsucik Apr 14, 2021
506cb25
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Apr 14, 2021
3548b55
Merge branch 'e2e-feature-combining-layers-2.2' of github.com:RasaHQ/…
samsucik Apr 14, 2021
652b972
Increase DIET's # of epochs for stable results of .
samsucik Apr 15, 2021
cfcc02d
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Apr 15, 2021
6ba4d78
Remove unused imports.
samsucik Apr 16, 2021
f83e85f
Split a method into two to avoid conflicting method name vs behaviour.
samsucik Apr 19, 2021
8133fbe
Merge branch 'main' of github.com:RasaHQ/rasa into e2e-feature-combin…
samsucik Apr 19, 2021
1bb5338
Fix a tiny bug.
samsucik Apr 19, 2021
044ed83
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 19, 2021
9dfb637
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 21, 2021
d6169e9
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 23, 2021
96de8a7
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 26, 2021
8e2a8a0
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 26, 2021
25d418b
Add dummy docstrings to satisfy code quality checks.
samsucik Apr 26, 2021
8735f0d
Add missing return type annotation.
samsucik Apr 26, 2021
308153d
Merge branch 'main' into e2e-feature-combining-layers-2.2
samsucik Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading