Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show telemetry state #7013

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Show telemetry state #7013

wants to merge 17 commits into from
+14 −0

Conversation

mbslet
Copy link
Contributor

@mbslet mbslet commented Oct 15, 2020

Proposed changes:
This Pull Request warns Telemetry state when rasa init commands run.

Resolves issue #6759

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

mbslet and others added 3 commits October 14, 2020 20:44
@mbslet @lucasdutraf @Henrike100
Add telemetry verification message to rasa init
096a622 
Signed-off-by: mbslet <[email protected]>
Co-authored-by: Lucas Dutra <[email protected]>
Co-authored-by: Henrike100 <[email protected]>
@mbslet @Henrike100 @lucasdutraf
Add changelog
cc7f351 
Signed-off-by: mbslet <[email protected]>
Co-authored-by: Henrike100 <[email protected]>
Co-authored-by: Lucas Dutra <[email protected]>
@mbslet
change print form
3149557
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @rgstephens will take a look at it as soon as possible ✨

rgstephens
rgstephens approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@rgstephens rgstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

Base automatically changed from master to main January 22, 2021 11:15
@alwx
Copy link
Contributor

alwx commented Jan 28, 2021

@rgstephens what's the status of this one? Can we merge it?

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iurisevero
Update verify telemetry func to use cli telemetry verification
b5d3ea7 
Avoid code duplication by reusing an alredy built func
@iurisevero
Copy link
Contributor

Hi @alwx, I've started working on the FGA-GCES/rasa repository and found this PR outdated, so I pulled rasa's latest version to it.
I also changed a little the _verify_telemetry function that was done before. Now it uses the inform_about_telemetry function, defined at rasa/cli/temeletry.py.

@ErickGiffoni ErickGiffoni deleted the show-telemetry-state branch August 5, 2021 19:42
@m-vdb
Copy link
Collaborator

m-vdb commented Dec 21, 2021

@mbslet @ErickGiffoni the original branch of this PR got deleted, would it be possible for you to restore it so that we can merge main into it and merge the PR?

@ErickGiffoni ErickGiffoni restored the show-telemetry-state branch December 21, 2021 15:24
@SamuelNoB SamuelNoB deleted the show-telemetry-state branch January 27, 2022 21:55
@stale
Copy link

stale bot commented Apr 28, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-vdb m-vdb m-vdb approved these changes

@rgstephens rgstephens rgstephens approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mbslet @sara-tagger @alwx @CLAassistant @iurisevero @m-vdb @rgstephens @Henrike100 @lucasdutraf @jppgomes