Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove np.array #6359

Merged
merged 7 commits into from
Aug 18, 2020
Merged

Remove np.array #6359

merged 7 commits into from
Aug 18, 2020

Conversation

JEM-Mosig
Copy link
Contributor

@JEM-Mosig JEM-Mosig commented Aug 7, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@JEM-Mosig JEM-Mosig requested a review from tabergma August 7, 2020 15:11
@JEM-Mosig JEM-Mosig added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Aug 7, 2020
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it. I still see

2020-08-10 08:49:11 INFO     rasa.nlu.model  - Starting to train component DIETClassifier
/Users/tabergma/Repositories/rasa/rasa/nlu/classifiers/diet_classifier.py:683: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray

when executing rasa train nlu. Can we please also fix this?

@JEM-Mosig
Copy link
Contributor Author

I just tested it. I still see

2020-08-10 08:49:11 INFO     rasa.nlu.model  - Starting to train component DIETClassifier
/Users/tabergma/Repositories/rasa/rasa/nlu/classifiers/diet_classifier.py:683: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray

when executing rasa train nlu. Can we please also fix this?

This is odd. It vanished for me once I removed the array. Perhaps this also depends on the Python version... I'll check later this week.

@JEM-Mosig
Copy link
Contributor Author

@tabergma What are your numpy and python versions?

@tabergma
Copy link
Contributor

python3.7 and numpy==1.19.1

Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Thanks 🚀

@JEM-Mosig JEM-Mosig merged commit 6a0a4ec into master Aug 18, 2020
@JEM-Mosig JEM-Mosig deleted the johannes-rasa6282 branch August 18, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Diet Classifier
2 participants