Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing in Message class #6251

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Fix typing in Message class #6251

merged 5 commits into from
Jul 22, 2020

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Jul 21, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb requested a review from dakshvar22 July 21, 2020 07:59
@m-vdb m-vdb mentioned this pull request Jul 21, 2020
4 tasks
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the types. Can you enhance the logic to handle the exception case?

Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 💯

rasa/nlu/training_data/message.py Outdated Show resolved Hide resolved
@rasabot rasabot merged commit 1fac70c into master Jul 22, 2020
@rasabot rasabot deleted the fix-message-type branch July 22, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants