[FEATURE] modify conversation id of server to accomodate viber id

[IzidoroBaltazar]

Proposed changes:

• Change conversation id format of server api to accommodate Viber channel

Status (please check what you already did):

• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[sara-tagger]

Thanks for submitting a pull request 🚀 @degiz will take a look at it as soon as possible ✨

[degiz]

Hey @IzidoroBaltazar

Could you please give example/point me to the viber doc with their conversation id formats?

I'm asking because I can't find examples with \ or / in them, and the +-_ are covered by the current string type.

[IzidoroBaltazar]

Here is general documentation.
https://developers.viber.com/docs/api/rest-bot-api/#get-user-details

From documentation you can see that = is used in user_id. We also know that user_id contains /, but documentation does not mention that. However we found multiple user_ids that contain / which caused problems with current server setup.

I have aggregated few problematic user_ids I see these characters:

+/1032547698=ACBEDGFIHKJMLONQPSRUTWVYXZacbedgfihkjmlonqpsrutwvyxz

Slash is usually somewhere in the string.

[degiz]

@IzidoroBaltazar

I see, thanks.
The case with +/1032547698=ACBEDGFIHKJMLONQPSRUTWVYXZacbedgfihkjmlonqpsrutwvyxz is covered if you use path type for the parameter, check here

Would it work for you? Seems easier to maintain compared to the regex.

Could you please also write an explicit test for this and call it something like test_post_conversation_id_with_slash?

[IzidoroBaltazar]

I have replaced regex with Sanic path it's working fine. I have modified the test test_push_multiple_events. This test is using problematic customer_id characters.

[degiz]

I have modified the test test_push_multiple_events

Exactly, we're trying to have one test per problem. So if test_push_multiple_events fails in the future bc of special symbols, it will be confusing. That's the reason I'm asking to add an explicit test_post_conversation_id_with_special_symbols.

[degiz]

Thanks a lot for wrapping that up! 🚀

[rasabot]

Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues.

[rasabot]

Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues.