Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide SQL password in logs #5849

Merged
merged 6 commits into from
May 19, 2020
Merged

Hide SQL password in logs #5849

merged 6 commits into from
May 19, 2020

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented May 18, 2020 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ricwo ricwo requested a review from tabergma May 18, 2020 16:48
@erohmensing
Copy link
Contributor

@ricwo just FYI, not sure if you saw #5841

@ricwo
Copy link
Contributor Author

ricwo commented May 18, 2020

I hadn't seen this - thanks @erohmensing

@ricwo ricwo mentioned this pull request May 18, 2020
Closed
4 tasks
tabergma
tabergma approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ricwo ricwo merged commit 2d2ee06 into master May 19, 2020
@ricwo ricwo deleted the hide-password branch May 19, 2020 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obfuscate passwords
3 participants
@ricwo @erohmensing @tabergma