Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-2760 Resolving compatibility issues with Microsoft Bot Framework emulator #5057

Merged
merged 6 commits into from
Jan 15, 2020
Merged

ISSUE-2760 Resolving compatibility issues with Microsoft Bot Framework emulator #5057

merged 6 commits into from
Jan 15, 2020

Conversation

justinas-b
Copy link
Contributor

@justinas-b justinas-b commented Jan 10, 2020 •
edited by erohmensing
Loading

@claassistantio
Copy link

claassistantio commented Jan 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@erohmensing
Copy link
Contributor

Thanks for the PR @justinas-b, it looks good! Can you please add a changelog entry via these instructions? The failing tests are something we're working on at the moment, and shouldn't be related to your changes.

@justinas-b
Copy link
Contributor Author

Hi @erohmensing , I have updated CHANGELOG

erohmensing
erohmensing approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a changelog entry! Modified it a bit for clarity.

@tmbo tmbo merged commit 6b879b6 into RasaHQ:master Jan 15, 2020
@erohmensing
Copy link
Contributor

Thanks for your contribution @justinas-b !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft Bot Framework Emulator unable to connect
4 participants
@justinas-b @claassistantio @erohmensing @tmbo