Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacy docker fix #4886

Merged
merged 5 commits into from
Dec 4, 2019
Merged

Spacy docker fix #4886

merged 5 commits into from
Dec 4, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Dec 2, 2019

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

If we link the spacy models, and uninstall spacy, and re-install spacy, the linking is lost.
@wochinge wochinge changed the base branch from master to 1.5.x December 2, 2019 17:17
@wochinge
Copy link
Contributor Author

wochinge commented Dec 4, 2019

@aleerizw Can you please give it a quick review?

@wochinge wochinge merged commit 93b0948 into 1.5.x Dec 4, 2019
@wochinge wochinge deleted the spacy-docker-fix branch December 4, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants