Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom logger bug #11971

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Fix custom logger bug #11971

merged 3 commits into from
Jan 26, 2023

Conversation

YahyaGrb
Copy link
Contributor

@YahyaGrb YahyaGrb commented Jan 26, 2023 •
edited
Loading

Proposed changes:

  • fixed custom logging file feature

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation : No need since no impact on docs, just internal fix
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@YahyaGrb YahyaGrb requested a review from a team as a code owner January 26, 2023 11:18
@YahyaGrb YahyaGrb requested review from znat and removed request for a team January 26, 2023 11:18
@YahyaGrb
Copy link
Contributor Author

Hi @ancalita , here is an updated version of the bug solving with the correct branch base.

@ancalita ancalita requested review from ancalita and removed request for znat January 26, 2023 13:13
ancalita
ancalita approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you again for spotting and fixing this bug 💯 🎉

@ancalita
Copy link
Member

Hi @ancalita , here is an updated version of the bug solving with the correct branch base.

I will merge this PR as soon as all the CI jobs pass (I will keep re-running them if they fail).

@ancalita ancalita merged commit 45d620b into RasaHQ:3.4.x Jan 26, 2023
@ancalita ancalita mentioned this pull request Nov 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YahyaGrb @ancalita