-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling errors #11458
base: main
Are you sure you want to change the base?
Fix spelling errors #11458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the corrections! Could you also please add a changelog entry of type misc
in the changelog directory? Please note I went ahead and merged main
in your branch, don't forget to pull these changes locally 😄
@ancalita, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
rasa/server.py
Outdated
@@ -593,7 +593,7 @@ async def wrapped() -> None: | |||
def run_in_thread(f: Callable[..., Coroutine]) -> Callable: | |||
"""Decorator which runs request on a separate thread. | |||
|
|||
Some requests (e.g. training or cross-validation) are computional intense requests. | |||
Some requests (e.g. training or cross-validation) are computational intense requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some requests (e.g. training or cross-validation) are computational intense requests. | |
Some requests (e.g. training or cross-validation) are computationally intense requests. # noqa: E501, W505 |
The comment is required to pass the Code Quality check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a line break should be added instead 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah! For some reason I thought this is the first line of the docstring and that always needs to end in .
My bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@thiagohdaqw in order to merge this PR, we need to fix the Code Quality fail (the other failing job is flaky, so we can re-run it until it passes. The linter is a bit temperamental, so even if you had not modified those specific lines, it will check for any irregularities in the file you made edits, let us know if you need any direction with solving these errors. Once solved, you can run
|
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)