Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling errors #11458

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

thiagohdaqw
Copy link
Contributor

@thiagohdaqw thiagohdaqw commented Aug 16, 2022

Proposed changes:

  • Fixed spelling erros in docs and code

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@thiagohdaqw thiagohdaqw requested review from a team as code owners August 16, 2022 02:12
@thiagohdaqw thiagohdaqw requested review from sanchariGr and removed request for a team August 16, 2022 02:12
@ancalita ancalita self-requested a review August 24, 2022 09:19
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the corrections! Could you also please add a changelog entry of type misc in the changelog directory? Please note I went ahead and merged main in your branch, don't forget to pull these changes locally 😄

@thiagohdaqw
Copy link
Contributor Author

@ancalita, done!
sry for the delay

@thiagohdaqw thiagohdaqw requested review from ancalita and removed request for sanchariGr September 6, 2022 01:43
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

rasa/server.py Outdated
@@ -593,7 +593,7 @@ async def wrapped() -> None:
def run_in_thread(f: Callable[..., Coroutine]) -> Callable:
"""Decorator which runs request on a separate thread.

Some requests (e.g. training or cross-validation) are computional intense requests.
Some requests (e.g. training or cross-validation) are computational intense requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Some requests (e.g. training or cross-validation) are computational intense requests.
Some requests (e.g. training or cross-validation) are computationally intense requests. # noqa: E501, W505

The comment is required to pass the Code Quality check.

Copy link
Contributor

@twerkmeister twerkmeister Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a line break should be added instead 😉

Copy link
Member

@ancalita ancalita Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! For some reason I thought this is the first line of the docstring and that always needs to end in . My bad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ancalita
Copy link
Member

ancalita commented Sep 9, 2022

@thiagohdaqw in order to merge this PR, we need to fix the Code Quality fail (the other failing job is flaky, so we can re-run it until it passes. The linter is a bit temperamental, so even if you had not modified those specific lines, it will check for any irregularities in the file you made edits, let us know if you need any direction with solving these errors. Once solved, you can run make lint in your terminal to check if everything passes.

Error: rasa/core/channels/mattermost.py:121:1: D102 Missing docstring in public method
Error: rasa/core/channels/slack.py:297:1: D202 No blank lines allowed after function docstring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants